[SeaBIOS] [PATCH 4/6] vgabios: split out an EDID part to a single file

[Kevin O'Connor]

On Sat, Sep 01, 2012 at 03:09:12PM +0900, Hiroshi Miura wrote:
[...]
> -u8 most_chromaticity[8] VAR16 = {0xA6,0x55,0x48,0x9B,0x26,0x12,0x50,0x54};
> -unsigned char vgabios_name[] VAR16 = "Sea VGABIOS";
> -struct edid_detailed_timing vbe_edid_dtd_1920x1080 VAR16 = {
> -     WORDBE(0x3a02), 0x80, 0x90, 0x72, 0x38, 0x26,
> -     0x40, 0x78, 0xD0, 0x13, 0x00, 0x14, 0x2B, 0x21,
> -     0x00, 0x00, 0x1E};

As previously noted, this is removing code just added in the previous
patch, which makes code review harder.  I suggest merging this patch
with patch 2 and 3.

[...]
> --- a/vgasrc/bochsvga.h
> +++ b/vgasrc/bochsvga.h
> @@ -67,7 +67,5 @@ int bochsvga_save_state(u16 seg, void *data, int states);
>  int bochsvga_restore_state(u16 seg, void *data, int states);
>  int bochsvga_set_mode(struct vgamode_s *vmode_g, int flags);
>  int bochsvga_init(void);
> -int bochsvga_get_ddc_capabilities(u16 unit);
> -int bochsvga_read_edid(u16 unit, u16 block, u16 seg, void *data);
>  
>  #endif // bochsvga.h
> diff --git a/vgasrc/vbe_edid.c b/vgasrc/vbe_edid.c
> new file mode 100644
> index 0000000..41570fc
> --- /dev/null
> +++ b/vgasrc/vbe_edid.c
> @@ -0,0 +1,136 @@
> +// VESA VBE EDID capability for virtual display
> +//

I'm okay with putting this code in its own file, but the code looks to
be specific to the bochsvga "dispi" interface.  As such, the code
should continue to use bochsvga_ prefixs and the filename should also
make that clear.

-Kevin