[SeaBIOS] [PATCH v2 9/9] seabios: Build the dsdt separately

Gerd Hoffmann kraxel at redhat.com
Thu Oct 11 08:29:48 CEST 2012


  Hi,

> Another point of discussion is the ordering of the commits to seabios
> vs. qemu. We could commit the above patch now (without the q35 aml, and
> with the acpi-dsdt.aml file).

Yes, that can go in separately.  Also the load-dsdt patch for piix.  And
run "make -C roms bios" once and "git add pc-bios/acpi-dsdt.aml".

> For q35, we could wait for the SeaBIOS bits to go in first, and then add
> the q35-acpi-dsdt.aml to pci-bios/. In that way, no special command line
> option will ever be required for q35 (except maybe -M pc_q35).

Once all q35 bits are in seabios we should update the seabios submodule
in qemu, again run "make -C roms bios" and commit the bios update
(including the new q35-acpi-dsdt.aml file).

commit 01afdadc92e71e29700e64f3a5f42c1c543e3cf9 is a bios update if you
wanna have an example to look at.

Then the need to use '-L' goes away.  That would be the final step once
all other q35 bits on both qemu + seabios are committed.

> The alternative would be to commit both trees in parallel, and have
> users of q35 specify -L <bios dir with q35 dsdt table>, until the
> q35-acpi-dsdt.aml is added to qemu.

Kevin tends to wait for the qemu bits being committed before applying
the corresponding patches to seabios.  So I think this would be the best
plan:

  (1) piix dsdt load patches (the stuff discussed above).
  (2) merge q35 series for qemu.
  (3) merge q35 series for seabios.
  (4) seabios update for qemu.

The q35 qemu series seems to be near ready for merge though,
so maybe it isn't worth splitting (1) + (2).

cheers,
  Gerd



More information about the SeaBIOS mailing list