[SeaBIOS] [PATCH v2 9/9] seabios: Build the dsdt separately
Michael S. Tsirkin
mst at redhat.com
Wed Oct 10 10:59:04 CEST 2012
On Tue, Oct 09, 2012 at 11:02:52AM -0400, Jason Baron wrote:
> On Tue, Oct 09, 2012 at 09:13:59AM +0200, Gerd Hoffmann wrote:
> > On 10/09/12 05:35, Jason Baron wrote:
> > > From: Jason Baron <jbaron at redhat.com>
> > >
> > > This builds seabios such that the dsdt tables are no longer built into the
> > > seabios binary. They must be passed to the seabios via fw_cfg. This saves
> > > space in the seabios binary for unnecessary dsdt tables.
> > >
> > > I suspect that this will make other users of Seabios, besides qemu unhappy,
> > > but I'm not sure.
> > I think this should best be submitted / discussed separately from the
> > q35 patch series. And dropping the dsdt from seabios will should
> > actually be the last step. Loading via fw_cfg works even when seabios
> > has a builtin dsdt. So we can start loading the dsdt via fwcfg
> > unconditionally in qemu without touching seabios. Once everything is in
> > place in qemu we can finally zap the builtin dsdt in seabios (or make it
> > a config option so latest seabios continues to work with older qemu
> > versions).
> Ok, I like this idea. My only hesitation would be that the dsdt table
> might in the future include a dependency on being built with seabios, such as
> the 'ACPI_EXTRACT_*' stuff. At the moment it can be cleanly separated
> out. And this patch enforces that.
> If we don't touch seabios here as you've suggested. What steps are
> required on the qemu side? To copy the 2 .aml files to its bios dir (Not
> too familiar with these details)?
I'm guessing if all of acpi is moved out of seabios we'll need
to move ACPI_EXTRACT_ stuff as well as the acpi parsing
out of there as well.
More information about the SeaBIOS