[SeaBIOS] [PATCH 5/8] Setup output based on .config
Christian Gmeiner
christian.gmeiner at gmail.com
Tue Oct 2 17:28:04 CEST 2012
2012/10/2 Kevin O'Connor <kevin at koconnor.net>:
> On Mon, Oct 01, 2012 at 02:02:46PM +0200, Christian Gmeiner wrote:
>> The geode hardware can be configured to use different
>> outputs. This patch adds support this feature based on
>> the current .config
> [...]
>> + if (CONFIG_VGA_OUTPUT_PANEL || CONFIG_VGA_OUTPUT_CRT_PANEL) {
>
> This patch seems to use kconfig defines that are only defined in patch
> 6. When sending a multi-series patch, it's important that each
> individual commit compiles and functions properly.
>
> Otherwise, the patch series seems fine to me.
>
Shall I resend a v2 which corrects this?
---
Christian Gmeiner, MSc
More information about the SeaBIOS
mailing list