[SeaBIOS] [PATCH 1/8] Rename defines to better match a well defined naming schema

Peter Stuge peter at stuge.se
Mon Oct 1 14:38:50 CEST 2012

Hi Christian,

Christian Gmeiner wrote:
> The following nameing schema is used:

The changes in the patch set look good to me, but *please* touch up
the commit message summaries so that it is obvious what the changes

The summary of the first patch:

"Rename defines to better match a well defined naming schema"

Says that this patch changes "defines" - and nothing more specific.

What defines?

Looking *at* the diffstat for the patch it is clear that only
geodevga is changed. The exact same thing applies to all the other

I would suggest to prefix all commit message summaries with



More information about the SeaBIOS mailing list