[SeaBIOS] [PATCH 18/20] acpi: move isa devices to separate file

[Hannes Reinecke]

Hi kraxel,

On 11/27/2012 10:21 AM, Gerd Hoffmann wrote:
> Stuff them parameterized into #defines, so we can (a) reuse them for
> q35 and (b) don't duplicate the serial line.
>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
>   src/acpi-dsdt-isa.dsl |  113 ++++++++++++++++++++++++++++++++
>   src/acpi-dsdt.dsl     |  171 +++----------------------------------------------
>   2 files changed, 122 insertions(+), 162 deletions(-)
>   create mode 100644 src/acpi-dsdt-isa.dsl
>
> diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl
> new file mode 100644
> index 0000000..ee8194d
> --- /dev/null
> +++ b/src/acpi-dsdt-isa.dsl
> @@ -0,0 +1,113 @@
> +#define ISA_DEVICE_RTC(_name)                                       \
> +    Device (_name)                                                  \
> +    {                                                               \
> +        Name (_HID, EisaId ("PNP0B00"))                             \
> +        Name (_CRS, ResourceTemplate ()                             \
> +        {                                                           \
> +            IO (Decode16, 0x0070, 0x0070, 0x10, 0x02)               \
> +            IRQNoFlags () {8}                                       \
> +            IO (Decode16, 0x0072, 0x0072, 0x02, 0x06)               \
> +        })                                                          \
> +    }
> +
> +#define ISA_DEVICE_PS2_KBD(_name)                                   \
> +    Device (KBD)                                                    \

Shouldn't that be
Device (_name) ?

> +    {                                                               \
> +        Name (_HID, EisaId ("PNP0303"))                             \
> +        Method (_STA, 0, NotSerialized)                             \
> +        {                                                           \
> +            Return (0x0f)                                           \
> +        }                                                           \
> +        Name (_CRS, ResourceTemplate ()                             \
> +        {                                                           \
> +            IO (Decode16, 0x0060, 0x0060, 0x01, 0x01)               \
> +            IO (Decode16, 0x0064, 0x0064, 0x01, 0x01)               \
> +            IRQNoFlags () { 1 }                                     \
> +        })                                                          \
> +    }
> +
> +#define ISA_DEVICE_PS2_MOUSE(_name)                                 \
> +    Device (MOU)                                                    \

Same here...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)