[SeaBIOS] [PATCH 1/6] remove iasl-generated hex files from git repo

Kevin O'Connor kevin at koconnor.net
Wed May 23 02:56:27 CEST 2012


On Tue, May 22, 2012 at 11:50:37AM +0200, Gerd Hoffmann wrote:
> On 05/18/12 05:16, Kevin O'Connor wrote:
> > On Tue, May 15, 2012 at 12:46:21PM +0200, Gerd Hoffmann wrote:
> >> Almost every linux distro has iasl packaged these days.
> >> Lets make it a build dependency and stop the hassle we
> >> have with updating the *.hex files in the git repo.
> > 
> > I'm a bit torn on this.  I see the gain in that it simplifies the
> > build and makes patches smaller.
> 
> Patch conflicts in the generated files are a pain too.
> 
> >  It also allows include files (eg,
> > config.h) to be pulled into the asl code so that symbolic names can be
> > shared.  Iasl is easily available from most distros, but it isn't
> > installed by default.  I don't want to scare off any casual users that
> > download the git tree and attempt to compile.
> 
> We can detect iasl and print a friendly message in case it isn't there,
> see attached patch.  Comments?

Yes - if we have a very clear message to the user it's probably okay.

-Kevin



More information about the SeaBIOS mailing list