[SeaBIOS] [PATCH 2/2] lsi53c895a boot support

Gerd Hoffmann kraxel at redhat.com
Fri Jul 20 09:33:05 CEST 2012


  Hi,

>> +    /* FIXME: probably not the best idea to have this on the stack ... */
>> +    u32 script[] = {
> 
> Several places in the code DMA to the stack already (usb-ehci,
> usb-uhci, ata).

My concern isn't DMA'ing to the stack, but the size of the script and
possible stack overruns.  But maybe it is a moot point with the stack
switching added to seabios recently.

cheers,
  Gerd




More information about the SeaBIOS mailing list