[SeaBIOS] [PATCH 0/5] pci: 64bit support

Gerd Hoffmann kraxel at redhat.com
Wed Feb 22 15:15:03 CET 2012

On 02/22/12 14:38, Kevin O'Connor wrote:
> On Wed, Feb 22, 2012 at 11:55:53AM +0100, Gerd Hoffmann wrote:
>>>> I haven't really had a chance to review it.  Initial thoughts were
>>>> - on patch 1, I'm not sure how that will impact stack usage which
>>>> is quite tight when running in 16bit mode;
>> Stack usage doesn't grow much I think.  struct pci_dev becomes larger,
>> but I doubt you can find those on the stack.  Some local variables move
>> from u32 to u64.  But doesn't run this code in 32bit anyway?
> I was referring to the changes to dprintf, which does run in 16bit
> mode.  There is a script tools/checkstack.py that can calculate the
> 16bit stack usages.

Ah.  That patch raises the stack usage indeed, even without printing
64bit hex numbers ...


More information about the SeaBIOS mailing list