[SeaBIOS] [PATCH] add virtio-scsi driver

Paolo Bonzini pbonzini at redhat.com
Wed Feb 15 15:12:51 CET 2012

On 02/15/2012 02:35 PM, Laszlo Ersek wrote:
> I've reviewed this patch for RHEL-6 and now diffed the RHEL-6 patch with
> this one. I think the differences are all OK (source file list, handling
> of the VIRTIO_SCSI config option, bdf vs. pci, contents of struct
> virtio_scsi_config).

Hm, no.  I included an old version of struct virtio_scsi_config.  It
does not matter because it is not really used (it is there only to keep
the virtio_scsi.h relatively complete), but it should not be wrong.

> The only thing that *might* be an oversight is virtio_scsi_cmd()
> checking for VIRTIO_BLK_S_OK as response status (instead of
> VIRTIO_SCSI_S_OK as in RHEL-6), even thogh t SeaBIOS pach also #defines
> the latter macro. They both expand to 0, so it's only a
> source-documentation question.

Will fix this too.  v2 on the way.


More information about the SeaBIOS mailing list