[SeaBIOS] [PATCH 1/3] vgahooks: Allow usage of VGA hooks in the Xen case

[Julian Pidancet]

On Wed, Feb 1, 2012 at 4:04 AM, Kevin O'Connor <kevin at koconnor.net> wrote:
> On Mon, Jan 30, 2012 at 01:55:54PM +0000, julian.pidancet at gmail.com wrote:
>> From: Julian Pidancet <julian.pidancet at citrix.com>
>>
>> This patch enables the VGAHOOKS config option if the BIOS is configured
>> for Xen.
>> In the Xen VGA passthrough case, the option ROM can be extracted from
>> the physical device by hvmloader and pre-deployed for seabios. This
>> patch also allows setting up VGA hooks in case the VGA option ROM is
>> already deployed by hvmloader.
>
> This seems a bit odd - if option roms are deployed, how can seabios
> reliably find the vga device?  Wouldn't it be simpler to just use
> seabios in non-optionrom-deployed mode?  (After all, wouldn't seabios
> still be able to pull the roms even if hvmloader alread did?)
>

I think you're right, I just checked the sources of hvmloader in
xen-unstable, and it seems the option roms are only pre-deployed when
using rombios instead of seabios. So this patch doesn't really make
sense after all.

-- 
Julian