[SeaBIOS] [PATCH 3/3] acpi: revert d9f5cdbdf (DSDT: Fix HPET _CRS Method)

Kevin O'Connor kevin at koconnor.net
Thu Dec 6 21:56:44 CET 2012


On Thu, Dec 06, 2012 at 06:10:46PM +0100, Alexander Graf wrote:
> You should be able to poke fw_cfg in the _STA method. The machine
> file could search its bus on init (or on machine create notify) and
> populate a fw_cfg variable to indicate whether it found an applesmc.

I don't think we should access fw_cfg from the AML code.  AML code is
already too fragile and I think accessing fw_cfg is just going to make
it worse.

There are existing mechanisms for dynamically generating AML code (see
the SeaBIOS SSDTs) and a way to pass parameters into the AML from
SeaBIOS (see the BDAT code).  Hopefully, this issue can be solved
without requiring these mechanisms or an additional information
passing mechanism.

-Kevin



More information about the SeaBIOS mailing list