[SeaBIOS] [PATCH] acpi: fix irq 8 ressource conflict

[Gabriel L. Somlo]

On Thu, Dec 06, 2012 at 09:33:50AM +0200, Gleb Natapov wrote:
> On Wed, Dec 05, 2012 at 05:28:31PM -0500, Kevin O'Connor wrote:
> > Looks like a regression caused by
> > d9f5cdbdf55d61aef9a1a534d9123ef734427478 - I'll revert that patch if
> > no fix is found.
> > 
> If it was copied from real HW can we check that XP runs on this HW?

HPET with both

                        Memory32Fixed (ReadOnly,
                            0xFED00000,         // Address Base
                            0x00000400,         // Address Length
                            )

and 

                        IRQNoFlags ()
                            {0}
                        IRQNoFlags ()
                            {8}

is from Apple hardware. I remember running XP on my MBP2,1 a few years
ago.

On a Dell Latitude D630, I have just

                        Memory32Fixed (ReadOnly,
                            0xFED00000,         // Address Base
                            0x00000400,         // Address Length
                            )

without the IRQNoFlags for the HPET's _CRS.

On the Macs, the RTC looks like this:

                Device (RTC) {
                    Name (_HID, EisaId ("PNP0B00"))
                    Name (_CRS, ResourceTemplate () {
                        IO (Decode16,
                            0x0070,             // Range Minimum
                            0x0070,             // Range Maximum
                            0x01,               // Alignment
                            0x08,               // Length
                            )
                    })
                }


On the Dell D630, it looks like this (more or less similar to SeaBIOS):

                Device (RTC) {
                    Name (_HID, EisaId ("PNP0B00"))
                    Name (RT, ResourceTemplate () {
                        IO (Decode16,
                            0x0070,             // Range Minimum
                            0x0070,             // Range Maximum
                            0x10,               // Alignment
                            0x02,               // Length
                            )
                        IRQNoFlags () {8}
                        IO (Decode16,
                            0x0072,             // Range Minimum
                            0x0072,             // Range Maximum
                            0x02,               // Alignment
                            0x06,               // Length
                            )
                    })
                    Method (_CRS, 0, NotSerialized) {
                        Return (RT)
                    }
                }

Kevin, Jason: if dropping only the IRQNoFlags line from HPET _CRS gets
XP working in your setup, can we just do that instead of fully reverting
d9f5cdbdf55d61aef9a1a534d9123ef734427478 ? At least that way OS X will
still work in single-core mode ?

Thanks,
--Gabriel