[SeaBIOS] [PATCH 3/3] acpi: revert d9f5cdbdf (DSDT: Fix HPET _CRS Method)

[Gabriel L. Somlo]

On Wed, Dec 05, 2012 at 05:31:25PM -0500, Kevin O'Connor wrote:
> Thanks.  It looks like ConcatenateResTemplate wasn't in the ACPI 1.0
> spec, so I think we should try to avoid using it.  (I know it's used
> by the 64bit PCI code, but any machine supporting 64bit PCI is likely
> to have a more recent OS.)
> 
> I put together a slightly modified patch - see separate email.
>
> ...
>
> Changing the hpet resource template appears to break WinXP, so revert
> the change.


Interestingly enough, even with the HPET _CRS reverted to its state
before d9f5cdbdf, I get (with qemu git master, and with seabios git master
plus the reverted hpet):

qemu-img create -f qcow2 xp.img
bin/qemu-system-x86-64 -enable-kvm -m2048 -bios bios-master.bin \
  -cdom ./XPSP2.iso -hda ./xp.img

A problem has been detected and Windows has been shut down...
...
STOP: 0x7e (0xC0000005,0xf73b8d66,0xf7d1ea0,0xf78d1b9c)
acpi.sys - address f73b8d66 base at f73ad000, datestamp 41107d27

I may be biased in favor of the d9f5cdbdf patch :) , but is there a
chance removing/reapplying it is just tickling some other problem ?

Thanks,
--Gabriel