[SeaBIOS] [PATCH v2 0/2] Add IPMI SMBIOS/ACPI support

[Kevin O'Connor]

On Fri, Aug 10, 2012 at 08:48:58AM -0500, Corey Minyard wrote:
> On 08/08/2012 11:11 AM, minyard at acm.org wrote:
> >I went ahead and kept the structure passing because I've added ACPI
> >support.  After thinking about it a while, I think if you have to
> >pass anything to SMBIOS (like "IPMI is present") you might as well
> >pass the whole structure, and making things fixed in the BIOS that
> >can change in the hardware doesn't seem like a good idea.
> >
> >Note that the acpi-element code might make building the SSDT table
> >a little cleaner, if that is interesting.
> I haven't heard anything on this patch set.  Any comments?

Patch 1 has the same problem as the last set - it introduces a new
struct to carry info from QEMU to SeaBIOS when a standard struct
(smbios) already exists.

Patch 2 is complex and I don't fully understand what it is doing.  A
quick scan leads me to believe it is constructing a dynamic SSDT -
though it's not clear why a dynamic SSDT is needed and why the
existing mechanism (see build_ssdt()) for generating dynamic SSDTs is
not used.

-Kevin