[SeaBIOS] [PATCH v2 6/6] acpi: build PCI hotplug devices from a single template

[Kevin O'Connor]

On Fri, Aug 03, 2012 at 08:49:00PM +0300, Michael S. Tsirkin wrote:
> On Thu, Aug 02, 2012 at 03:07:26PM +0200, Paolo Bonzini wrote:
> > More than 1kb of data is taken by the 32 copies of the PCI hotplug SSDT
> > methods.  We can build them from a single template like we do for CPUs
> > (wrapped in a Scope(\_SB.PCI0) block).
> > 
> > Three items differ for each slot: the device name, bits 16-23 of _ADR,
> > the _SUN value.  On top of this we have to rename the eject method for
> > non-removable slots, like we already do in build_pcihp.
> > 
> > There is a small change in the ASL: instead of including the number of
> > the slot in the implementation of _EJ0, we just call _SUN.  This is also
> > similar to what we do for CPU hotplug.
> > 
> > Once we do this, there is no need to keep a separate SSDT for PCI hotplug.
> > Everything can reside in the same table.
> 
> Size was never a reason to keep it separate. This was suggested by
> Kevin, the idea was to make it easier for people to override the hotplug
> logic. Does this still apply? Kevin?

I don't recall suggesting it being separate - my recollection was
preferring to dynamically generate more of the PCI hotplug so as to be
more like cpu hotplug.

-Kevin