[SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code

[Idwer Vollering]

2012/8/2 Michael S. Tsirkin <mst at redhat.com>:
> On Tue, Jul 31, 2012 at 09:12:51PM -0400, Kevin O'Connor wrote:
>> On Tue, Jul 31, 2012 at 08:02:45PM +0200, Idwer Vollering wrote:
>> > 2012/7/31 Moore, Robert <robert.moore at intel.com>:
>> > > Please let me know if the -Pn option works for you.
>> > > Thanks,
>> > > Bob
>> >
>> > -Pn works for me, on acpica-20120420-64.
>>
>> It looks like "-Pn" only works on newer versions of iasl.  Can you
>> confirm the SeaBIOS patch below works with a newer iasl?
>>
>> -Kevin
>
> It doesn't work for me.

Can you try acpica-unix-20120215?

>
> BTW you can clone from:
>
> git://github.com/otcshare/acpica.git
>
> Then just cd acpica, then make and iasl will be generated in
> generate/unix/iasl/obj32/iasl
>
> The following works for me with latest iasl from git as well
> as 20100528 that Fedora 17 ships.
>
> --->
>
> acpi: fix build with new iasl compiler
>
> iasl versions starting with 20120320
> (git commit 7fd09d993580e22a096a1b21d2a356d89e702153) enable
> a preprocessor by default, which currently strips out
> comments from the input. Happily the next release,
> 20120420, includes an option to disable the preprocessor.
> Test and use this option when available.
>
> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
>
> ---
>
> diff --git a/Makefile b/Makefile
> index dfdec5c..849824d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -221,11 +221,14 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py
>
>  ################ DSDT build rules
>
> +iasl-option=$(shell if "$(1)" "$(2)" -h > /dev/null 2>&1 \
> +    ; then echo "$(2)"; else echo "$(3)"; fi ;)
> +
>  $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py
>         @echo "  Compiling IASL $@"
>         $(Q)cpp -P $< > $(OUT)$*.dsl.i.orig
>         $(Q)$(PYTHON) ./tools/acpi_extract_preprocess.py $(OUT)$*.dsl.i.orig > $(OUT)$*.dsl.i
> -       $(Q)$(IASL) -vs -l -tc -p $(OUT)$* $(OUT)$*.dsl.i
> +       $(Q)$(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $(OUT)$* $(OUT)$*.dsl.i
>         $(Q)$(PYTHON) ./tools/acpi_extract.py $(OUT)$*.lst > $(OUT)$*.off
>         $(Q)cat $(OUT)$*.off > $@
>