[SeaBIOS] [PATCH 1/2] lsi: do not reset on error

Paolo Bonzini pbonzini at redhat.com
Thu Aug 2 18:22:43 CEST 2012


Resetting on any error (including for example a disconnected device)
will cause a unit attention condition on all devices.  So if we cannot
probe for example target 6, the first read on target 0 will fail.

Reported-by: Frediano Ziglio <freddy77 at gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
---
 src/lsi-scsi.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/src/lsi-scsi.c b/src/lsi-scsi.c
index 949d3f4..b70b3a5 100644
--- a/src/lsi-scsi.c
+++ b/src/lsi-scsi.c
@@ -115,8 +115,6 @@ lsi_scsi_cmd(struct lsi_lun_s *llun, struct disk_op_s *op,
     }
 
 fail:
-    // sledge hammer to get back into a known-good state: hba reset
-    outb(LSI_ISTAT0_SRST, iobase + LSI_REG_ISTAT0);
     return DISK_RET_EBADTRACK;
 }
 
-- 
1.7.10.4





More information about the SeaBIOS mailing list