[SeaBIOS] Compiling SeaBIOS for coreboot has problems with its ACPI code

[Moore, Robert]

Here is the history:

20120320: Preprocessor added to iASL compiler
20120420: -Pn option added to disable preprocessor

The preprocessor is new, but we decided to add the -Pn option just in case any issues like you have encountered came up.



>-----Original Message-----
>From: Kevin O'Connor [mailto:kevin at koconnor.net]
>Sent: Tuesday, July 31, 2012 6:13 PM
>To: Idwer Vollering
>Cc: Moore, Robert; Michael S. Tsirkin; seabios at seabios.org; Tang, Feng
>Subject: Re: [SeaBIOS] Compiling SeaBIOS for coreboot has problems with its
>ACPI code
>
>On Tue, Jul 31, 2012 at 08:02:45PM +0200, Idwer Vollering wrote:
>> 2012/7/31 Moore, Robert <robert.moore at intel.com>:
>> > Please let me know if the -Pn option works for you.
>> > Thanks,
>> > Bob
>>
>> -Pn works for me, on acpica-20120420-64.
>
>It looks like "-Pn" only works on newer versions of iasl.  Can you
>confirm the SeaBIOS patch below works with a newer iasl?
>
>-Kevin
>
>
>--- a/Makefile
>+++ b/Makefile
>@@ -221,11 +221,14 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw
>tools/buildrom.py
>
> ################ DSDT build rules
>
>+iasl-option=$(shell if test -z "`$(1) $(2) -h 2>&1 > /dev/null" \
>+    ; then echo "$(2)"; else echo "$(3)"; fi ;)
>+
> $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py
>./tools/acpi_extract.py
>        @echo "  Compiling IASL $@"
>        $(Q)cpp -P $< > $(OUT)$*.dsl.i.orig
>        $(Q)$(PYTHON) ./tools/acpi_extract_preprocess.py
>$(OUT)$*.dsl.i.orig > $(OUT)$*.dsl.i
>-       $(Q)$(IASL) -vs -l -tc -p $(OUT)$* $(OUT)$*.dsl.i
>+       $(Q)$(IASL) $(iasl-option,$(IASL),-Pn,) -vs -l -tc -p $(OUT)$*
>$(OUT)$*.dsl.i
>        $(Q)$(PYTHON) ./tools/acpi_extract.py $(OUT)$*.lst > $(OUT)$*.off
>        $(Q)cat $(OUT)$*.off > $@