[SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

[Alexey Korolev]

Hi
Thank you for review!
On 26/04/12 03:29, Gerd Hoffmann wrote:
>> Okay - I missed that.  I think the patches look okay to be committed -
>> any additional changes can be made on top.  Gerd - do you have any
>> comments?
> Great job overall.  Can't spot issues in the code.  And the patches do
> fine in testing too.  Some minor issues poped up:
>
> Issue #1:  seabios can't boot from a virtio-scsi disk if the controller
> is behind a pci bridge.  I think the reason simply is that (according to
> the seabios log) only root bus pci devices are initialized.  Probably
> even isn't related to this patch set, just trapped into this while
> testing the bridge mapping code of the patch series.
I observed similar but ignored since "bridge test" requires special qemu build.
It's a general bridge support issue. This series don't address this issue.
This issue occurs regardless if the patches applied or not.

> Issue #2: root bus (non-pref) memory regions are mapped above 4G if they
> are 64bit capable.  That happened to include the xhci usb controller.  I
> don't think we want that.  Some day seabios will get xhci support, and
> having the bar above 4G makes it unreachable in 32bit mode.  So this
> needs some refinement.  Options I can think of:
>
>   (1) Don't bother mapping non-prefmem bars above 4G.
>   (2) Only map them above 4G if they are larger than a certain limit.
>   (3) Allow devices to be excluded on certain conditions, for example
>       when seabios has a driver, when they have an option rom, when
>       they have a specific pci id, ...
I like (3) more than the (1) and (2).

> These are certainly no blockers and can be discussed and solved after
> committing this series.

I've just fixed what you have suggested to fix.
Just very minor changes in patches 10/12 and 11/12:
- Simplify a bit list operation.
- Remove function calls away of macros
- Add condition to check crossing the end of 64bit PCI range

Thanks,
Alexey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-Fix-64bit-PCI-issues-on-Windows.patch
Type: text/x-patch
Size: 2545 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0012.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-pciinit-Migrate-64bit-entries-to-64bit-pci-regions.patch
Type: text/x-patch
Size: 4168 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0013.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-pciinit-Calculate-pci-region-stats-on-demand.patch
Type: text/x-patch
Size: 4304 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0014.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-pciinit-64bit-capability-discovery-for-pci-bridges.patch
Type: text/x-patch
Size: 2350 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0015.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-pciinit-Add-pci_region-structure.patch
Type: text/x-patch
Size: 3537 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0016.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-pciinit-Switch-to-64bit-variable-types.patch
Type: text/x-patch
Size: 11021 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0017.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-pciinit-bridges-can-have-two-regions-too.patch
Type: text/x-patch
Size: 1736 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0018.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-pciinit-Track-region-alignment-explicitly.patch
Type: text/x-patch
Size: 5638 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0019.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-pciinit-Use-sorted-order-allocation.patch
Type: text/x-patch
Size: 5354 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0020.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-pciinit-Remove-size-element-from-pci_bus-r-structure.patch
Type: text/x-patch
Size: 2428 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0021.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pciinit-Move-bus-bar-asignment.patch
Type: text/x-patch
Size: 4350 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0022.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pciinit-Introduction-of-pci_region_entry-structure.patch
Type: text/x-patch
Size: 7988 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20120426/de00a248/attachment-0023.patch>