[SeaBIOS] [PATCH] Set numa topology for max_cpus

Kevin O'Connor kevin at koconnor.net
Fri Oct 28 02:06:17 CEST 2011

On Wed, Oct 26, 2011 at 02:19:00PM +0200, Vasilis Liaskovitis wrote:
> qemu-kvm passes numa/SRAT topology information for smp_cpus to SeaBIOS. However
> SeaBIOS always expects to setup max_cpus number of SRAT cpu entries
> (MaxCountCPUs variable in build_srat function of Seabios). When qemu-kvm runs
> with smp_cpus != max_cpus (e.g. -smp 2,maxcpus=4), Seabios will mistakenly use
> memory SRAT info for setting up CPU SRAT entries for the offline CPUs. Wrong
> SRAT memory entries are also created. This breaks NUMA in a guest.
> Fix by setting up SRAT info for max_cpus in qemu-kvm.
> Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis at profitbricks.com>

It looks okay to me, but I'd like to see an Ack from a QEmu or KVM


More information about the SeaBIOS mailing list