[SeaBIOS] [PATCH 0/6] PCI init code refactoring

Kevin O'Connor kevin at koconnor.net
Sat Oct 1 21:01:33 CEST 2011


Some cleanups to the pciinit.c code.

These are some things I noticed while tracking down the recent bug
reports caused by calling ALIGN_DOWN with a zero alignment.  The fix
to that bug was small enough to commit immediately.  However, I think
it would be worthwhile to also commit the cleanups I found.

Given this is just a cleanup, I don't intend to commit until after
v1.6.3 is tagged.

-Kevin


Kevin O'Connor (6):
  Use standard formatting for PCI info during PCI init pass.
  Separate pciinit.c into clearly delineated sections.
  Simplify pci_bios_init_root_regions().
  Use pci->header_type in pci_bar() to avoid unnecessary
    pci_config_readb.
  Introduce PCI child device iterators and use in pciinit.c.
  Simplify pci_slot_get_irq().

 src/pci.c     |    2 +
 src/pci.h     |   12 ++
 src/pciinit.c |  337 +++++++++++++++++++++++++++------------------------------
 3 files changed, 173 insertions(+), 178 deletions(-)

-- 
1.7.6.2




More information about the SeaBIOS mailing list