[SeaBIOS] non-emulated AHCI hardware

Gerd Hoffmann kraxel at redhat.com
Thu May 26 14:00:22 CEST 2011


> Attached is a two part version of the previous patch. Stage1 is enough
> to get through most OS installs. Stage2 adds unaligned buffer support
> needed for MS-DOS.

Hmm, patch #1 is still a collection of multiple changes, looks a bit 
like trying this and that until it somehow worked, without figuring 
which changes where needed to make the box boot.  Also the changelog 
should describe what was changed and why, not only the effect of the change.

Polling the IRQ status looks like a sensible thing to do.  Note that 
there might be multiple bits set in the IRQ status register, so you 
can't use irqbits == 0x01 to check the status.  qemu fails to boot 
because of that bug.  Also it isn't obvious why you are looking for 
others than the "Device to Host Register FIS" interrupt.  Care to explain?

I've attached a patch which switches ahci over to irq status polling, 
based on your patch.  Works nicely in qemu.  Can you give it a spin on 
real hardware?

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-ahci-use-interrupt-status-register.patch
URL: <http://www.seabios.org/pipermail/seabios/attachments/20110526/b7b312b4/attachment.ksh>

More information about the SeaBIOS mailing list