[SeaBIOS] [PATCH] fix resume from S3 with QXL device

Gleb Natapov gleb at redhat.com
Thu May 19 08:41:47 CEST 2011


On Thu, May 19, 2011 at 09:35:52AM +0300, Alon Levy wrote:
> On Wed, May 18, 2011 at 07:51:21PM -0400, Kevin O'Connor wrote:
> > On Wed, May 18, 2011 at 03:47:28PM +0300, Alon Levy wrote:
> > > From: Gleb Natapov <gleb at redhat.com>
> > > 
> > > QXL device is powered down during S3, so tell this to a guest OS
> > > in AML code.
> > > 
> > > Signed-off-by: Gleb Natapov <gleb at redhat.com>
> > > ---
> > > I'm sending this after talking to Gleb who ok-ed it. Note that I've added
> > > the compiled dsl file since it was already checked in. Should I send this as
> > > two patches?
> > > 
> > > Also, my understanding is that the acpi part is only used by qemu, not on
> > > physical hardware, so no need to test it on anything else, correct?
> > 
> > Thanks.
> > 
> > Is the patch from you Alon, or did Gleb write it?  Does this depend on
> > a change to qemu/kvm code or is this separate?
> > 
> 
> Gleb wrote it, I set the Author to him, and the Signed-off-by I kept. This
> is a cleaned up commit from the rhel-6 internal tree. (cleaned up - removed
> a space :)
> 
I haven't submitted it upstream when I wrote it because back then QXL
was not in qemu yet.

> > It's not necessary to test ACPI changes on physical hardware.  It's
> > fine to send the dsl file, but not necessary as I can regenerate it as
> > well.
> 
> Ok.
> 
> > 
> > -Kevin

--
			Gleb.



More information about the SeaBIOS mailing list