[SeaBIOS] [PATCH] support T13 EDD3.0 spec

[Sebastian Herbszt]

Gleb Natapov wrote:
> On Thu, Jan 06, 2011 at 09:00:00AM -0500, Kevin O'Connor wrote:
>> On Thu, Jan 06, 2011 at 03:53:57PM +0200, Gleb Natapov wrote:
>> > On Thu, Jan 06, 2011 at 08:41:11AM -0500, Kevin O'Connor wrote:
>> > > On Thu, Jan 06, 2011 at 07:09:27AM +0200, Gleb Natapov wrote:
>> > > > On Wed, Jan 05, 2011 at 09:32:33PM -0500, Kevin O'Connor wrote:
>> > > > > > -        SET_INT13DPT(regs, host_bus[3], 0);
>> > > > > > +        SET_INT13DPT(regs, host_bus[3], ' ');
>> > > > > 
>> > > > > What if we're not in t13 mode?  Should this be:
>> > > > >   u8 fillchar = t13 ? ' ' : 0;
>> > > > >   SET_INT13DPT(regs, host_bus[3], fillchar);
>> > > > > 
>> > > > Phoenix does not specify padding. Are you sure phoenix has to have zero
>> > > > padding?
>> > > 
>> > > I think RBIL documented 0s.  It may not be important.
>> > > 
>> > What is RBIL?
>> 
>> Sorry - Ralph Brown's interrupt list:
>> 
>> http://www.cs.cmu.edu/~ralf/files.html
>> 
> Ah, I have it, just didn't know it is called RBIL :).
> 
> Do you want me to resend with fillchar = t13 ? ' ' : 0; or space should
> be good enough?

I suggest to keep the current behaviour if a buffer size of 66 bytes is supplied; this patch
would then be a no-op for buffers < 74.

Sebastian