[SeaBIOS] [PATCH v2] Make pci memory window configurable.

[Kevin O'Connor]

On Fri, Apr 29, 2011 at 09:37:05AM +0200, Gerd Hoffmann wrote:
> On 04/29/11 02:41, Kevin O'Connor wrote:
> >On Thu, Apr 28, 2011 at 08:28:40PM -0400, Kevin O'Connor wrote:
> >[...]
> >>I think it would be better to define the kconfig variables needed (eg,
> >>PCIMEM_START, PCIMEM_SIZE, PCIMEM_PREFMEM_SIZE) [...]
> >
> >Hrmm - on second thought, we know the PCI range should end at
> >0xfec00000, so I think kconfig only really needs to ask for
> >PCIMEM_SIZE and PCIMEM_PREFMEM_SIZE.
> 
> I think it is better to ask for the start address, then calculate
> the memory window size like the patch does as the size is a odd
> value (0x0ec00000) and I guess for most people it isn't obvious why
> ...
> 
> In case we have a separate window prefetchable memory we'll need one
> of the sizes too (then calculate the other).

That's fine with me.

> Is there any reason why there is a fixed split, other than making
> the code simpler (i.e. need only one instead of two passes over all
> pci devices)?

I think the only reason is that a two pass PCI scan is more work than
anyone wanted to do.

-Kevin