[SeaBIOS] [PATCH v3 0/2] pciinit: fix overflow when bar allocation
kevin at koconnor.net
Sun Nov 7 18:14:49 CET 2010
On Thu, Oct 28, 2010 at 03:54:34PM +0900, Isaku Yamahata wrote:
> Changes v2 -> v3:
> - use [first, last] instead of [start, end)
> Changes v1 -> v2:
> - add comment.
> Patch description:
> This patch set fixes PCI bar allocation when bar overflow occured.
> I checked if pmm_alloc facility can be used, but it doesn't suit for
> pci bar allocation. So I resulted in new API, pci_region which
> encapsulates region allocation and overflow checks.
> The first patch introduces pci_region, and the second patch fixes
> the overflow case with pci_region.
Looks okay to me. If there are no further comments, I'll commit.
BTW, as a minor nit - I'd prefer to put function descriptions in the
.c file next to the code instead of in the .h file - no need to resend
the patch though.
More information about the SeaBIOS