[SeaBIOS] [PATCHv2] fix two issues with virtio-blk

Gleb Natapov gleb at redhat.com
Tue May 18 07:19:03 CEST 2010


On Mon, May 17, 2010 at 07:27:30PM -0400, Kevin O'Connor wrote:
> On Mon, May 17, 2010 at 04:27:27PM +0300, Gleb Natapov wrote:
> > 1. Check if blk_size is valid in virtio_blk config.
> > 2. Disable interrupt otherwise interrupt may stuck
> >    with some guests.
> > 
> > Signed-off-by: Gleb Natapov <gleb at redhat.com>
> 
> Thanks.  I committed your change to my local repo.  I don't much like
> that goto though - is it okay if we break up virtio_blk_setup with the
> patch below (on top of your patch)?
> 
Yes, but the previous code bailed out from virtio_blk_setup() completely
if allocation failed. What is the point to continue trying to allocate
same amount of memory again and again. You patch changes this. What
about making init_virtio_blk() return -1 on failure and check return
value in virtio_blk_setup()?

--
			Gleb.



More information about the SeaBIOS mailing list