[SeaBIOS] [PATCH 4/8] seabios: pciinit: make pci bar assigner preferchable memory aware.

Kevin O'Connor kevin at koconnor.net
Tue Jun 22 06:05:52 CEST 2010

On Tue, Jun 22, 2010 at 12:22:50PM +0900, Isaku Yamahata wrote:
> On Mon, Jun 21, 2010 at 10:20:14PM -0400, Kevin O'Connor wrote:
> > How can we be sure that the "mem" space doesn't overlap with the
> > "prefmem" space?
> No check at the moment. Which way do you prefer?
> - do nothing and pray that user wouldn't add so many devices.
>   (current implementation)
>   I chose this implementation because the existing code doesn't
>   check whether mem area overlaps with around 4GB area which is
>   used for other purpose.
> - add overlap check.
>   If mem area reaches to perfmem area, abandon further mapping with warning.

I'd probably go with "add overlap check".  I could be convinced
otherwise though.


More information about the SeaBIOS mailing list