[SeaBIOS] [PATCH 8/8] seabios: pciinit: initialize pci bridge filtering registers.

Kevin O'Connor kevin at koconnor.net
Tue Jun 22 04:30:37 CEST 2010


On Thu, Jun 17, 2010 at 08:03:16PM +0900, Isaku Yamahata wrote:
> initialize pci bridge filtering registers.
[...]
> +static void pci_bios_init_device_bridge(u16 bdf)
> +{
> +    u32 io_old;
> +    u32 mem_old;
> +    u32 prefmem_old;

It would be preferable if C99 initializations were used here -
especially since there are already C99 declarations introduced later
in this function.

BTW, my other comments/questions aside, the patch series looks good to
me.

-Kevin



More information about the SeaBIOS mailing list