[SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

Avi Kivity avi at redhat.com
Mon Jun 14 16:51:27 CEST 2010


On 06/14/2010 05:09 PM, Gleb Natapov wrote:
>> Could we just have qemu build the hpet tables and pass them through to
>> seabios?  Perhaps using the qemu_cfg_acpi_additional_tables() method.
>>
>>      
> Possible, and I considered that. I personally prefer to pass minimum
> information required for seabios to discover underlying HW and leave
> ACPI table creation to seabios. That is how things done for HW that
> seabios can actually detect. If we will go your way pretty soon we will
> move creation of ACPI/SMBIOS/MP tables into qemu and IMHO this will be
> step backworkds.
>    

I agree.  ACPI is a firmware/OS interface.  If we move ACPI table 
generation into qemu, it becomes a mixed hardware/firmware/OS interface.

Better keep those interfaces separate: hardware/firmware (fwcfg) and 
firmware/OS (acpi).

-- 
error compiling committee.c: too many arguments to function




More information about the SeaBIOS mailing list