[SeaBIOS] [PATCH] EDD fixes

[Kevin O'Connor]

On Sat, Jul 31, 2010 at 09:02:24PM +0200, Sebastian Herbszt wrote:
> Kevin O'Connor wrote:
> >On Sat, Jul 31, 2010 at 05:26:09PM +0200, Sebastian Herbszt wrote:
> >>Fix data returned in the int13dpt structure.
> >[...]
> >>-    if (size < 66) {
> >>+    if (size < 74) {
> >>        disk_ret(regs, DISK_RET_SUCCESS);
> >>        return;
> >>    }
> >
> >This is not correct - the EDD v3.0 spec has a 66 byte structure.
> 
> You mean the Phoenix spec (BIOS Enhanced Disk Drive Specification,
> Version 3.0, Rev 0.8, March 12, 1998).
> 
> What about the T13 Working Draft, D1572, Information Technology - BIOS
> Enhanced Disk Drive Services - 3 (EDD-3), Revision 3, November 5, 2004?

Heh.  It looks like the standards are confusingly named.  The T13
EDD-1 spec is actually newer than the Phoenix EDD 3 spec.  At least by
looking at the specs at: http://www.t10.org/t13/#Project_drafts

So, I guess you are right and the bios should support 74 byte callers.
However, I also think it should still support 66 byte callers as there
may be something out there coded to the Phoenix spec.

-Kevin