[SeaBIOS] [PATCH 8/9] Record boot priority for each BAID/BCV/BEV.

Kevin O'Connor kevin at koconnor.net
Fri Dec 24 20:59:52 CET 2010


On Thu, Dec 23, 2010 at 11:29:42AM +0200, Gleb Natapov wrote:
> For each BAID/BCV/BEV lookup its boot priority in boot order file. If
> there is no entry for a device there assign it the lowest boot priority.
> 
> Signed-off-by: Gleb Natapov <gleb at redhat.com>

It's not clear what the floppy part of this patch does.  Can you
expand on that, or better yet, pull it out into its own patch?

The non-floppy parts look fine.

I think what the floppy stuff is doing is ordering the drives based on
its priority, but that seems like it will conflict with the boot menu
code which can also swap the floppy drives around.  Maybe we can add
floppies to the BCV list and have run_bcv() call map_floppy_drive()?
That way we use the same prioritization code for hds and floppies.

Also, if you respin patch 8, my preference would be to have patch 8
come before patch 5 (with all the bootprio_XXX() functions stubbed
out).

-Kevin



More information about the SeaBIOS mailing list