[SeaBIOS] [PATCHv2] add write support to virtio-blk

Gleb Natapov gleb at redhat.com
Sat Aug 21 22:02:54 CEST 2010


On Sat, Aug 21, 2010 at 03:12:32PM -0400, Kevin O'Connor wrote:
> On Wed, Aug 18, 2010 at 05:46:20PM +0300, Gleb Natapov wrote:
> > Windows XP does write to sector 0 during installation and prints
> > mysterious error if write fails. Interestingly if write drops data,
> > but returns OK to Windows installer installation proceed without
> > complains and completes successfully.
> [...]
> > +    case CMD_FORMAT:
> >          return DISK_RET_EWRITEPROTECT;
> 
> If CMD_WRITE is implemented, I think CMD_FORMAT should just return
> DISK_RET_SUCCESS (as ata does).
> 
Can you explain why? What CMD_FORMAT is suppose to do? May be it is just
a nop for virtio disk and returning success is much better in this case.

> Otherwise, looks okay to me.
> 
> -Kevin

--
			Gleb.



More information about the SeaBIOS mailing list