[SeaBIOS] Alt SeaBIOS SSDT cpu hotplug

Liu, Jinsong jinsong.liu at intel.com
Fri Aug 6 05:46:08 CEST 2010


Kevin O'Connor wrote:
> On Tue, Aug 03, 2010 at 05:00:49PM +0800, Liu, Jinsong wrote:
>> I just test your new patch with Windows 2008 DataCenter at my
>> platform, it works OK! We can hot-add new cpus and they appear at
>> Device Manager.  (BTW, yesterday I test your new patch with linux
>> 2.6.32 hvm, it works fine, we can add-remove-add-remove... cpus)
>> Sorry for make you spend more time. It's our fault.
> 
> Thanks.
> 
> I'll go ahead and commit it then.  I have one incremental patch (see
> below) which I will also commit.
> 
> -Kevin
> 
> 
> --- ssdt-proc.dsl       2010-08-03 18:45:12.000000000 -0400
> +++ src/ssdt-proc.dsl   2010-08-03 18:45:17.000000000 -0400
> @@ -44,7 +44,7 @@
>              Return(CPST(ID))
>          }
>          Method (_EJ0, 1, NotSerialized) {
> -            Return(CPEJ(ID, Arg0))
> +            CPEJ(ID, Arg0)
>          }
>      }
>  }

Kevin,

We find the root cause why your patch works fine at some platform but fail at other platform:
1). At platform A, success, use old qemu-kvm, commit is 3925c857a5740f62b30a5334f02477a23b61cc33
2). At platform B, fail, use new qemu-kvm, commit is 59d71ddb432db04b57ee2658ce50a3e35d7db97e
so seabios is OK, but qemu-kvm has bug.
I have fix it and send to kvm maillist.

With the fix qemu-kvm patch, and latest seabios and latest qemu-kvm, we re-do test,
now vcpu hotplug works fine with both linux2.6.32 and win2k8 datacenter.

Thanks,
Jinsong


More information about the SeaBIOS mailing list