[OpenBIOS] [PATCH 04/11] bootcode_load: ensure LOADER_NOT_SUPPORT is returned if no bootcode is present

[Mark Cave-Ayland]

On 26/05/18 22:32, Programmingkid wrote:

>> On May 26, 2018, at 3:29 PM, Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk> wrote:
>>
>> Otherwise we try unsucessfully to load the bootcode and fail rather than continuing
>> on to the next loader.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>
>> ---
>> libopenbios/bootcode_load.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libopenbios/bootcode_load.c b/libopenbios/bootcode_load.c
>> index 2a307ae..f472eba 100644
>> --- a/libopenbios/bootcode_load.c
>> +++ b/libopenbios/bootcode_load.c
>> @@ -8,6 +8,7 @@
>> #include "libopenbios/bindings.h"
>> #include "libopenbios/bootcode_load.h"
>> #include "libopenbios/initprogram.h"
>> +#include "libopenbios/sys_info.h"
>> #include "libc/diskio.h"
>> #include "drivers/drivers.h"
>> #define printf printk
>> @@ -33,6 +34,7 @@ bootcode_load(ihandle_t dev)
>>         loading bootcode via %BOOT */
>>      bootcode_info = find_ih_method("get-bootcode-info", dev);
>>      if (!bootcode_info) {
>> +        retval = LOADER_NOT_SUPPORT;
> 
> Why is this LOADER_NOT_SUPPORT and not LOADER_NOT_SUPPORTED?

Only because that's the constant already defined and used by the other 
loaders in OpenBIOS :)


ATB,

Mark.