[OpenBIOS] [PATCH 2/2] 40p: update PReP configuration to match 40p machine

[Mark Cave-Ayland]

On 27/08/18 15:17, Programmingkid wrote:

>> On Aug 27, 2018, at 8:24 AM, Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk> wrote:
>>
>> Now that the QEMU PReP machine has been officially deprecated we should
>> switch over the OpenBIOS PReP configuration to match the 40p machine
>> instead.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>
>> ---
>> arch/ppc/qemu/init.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/ppc/qemu/init.c b/arch/ppc/qemu/init.c
>> index af15682..c40b7df 100644
>> --- a/arch/ppc/qemu/init.c
>> +++ b/arch/ppc/qemu/init.c
>> @@ -113,7 +113,7 @@ int has_adb(void)
>>
>> static const pci_arch_t known_arch[] = {
>>     [ARCH_PREP] = {
> 
> I just had a question about this constant. Should it be changed to ARCH_IBM40P?

I did think about that, however it is an enum and will also be
referenced as PReP throughout the related QEMU code (at least until -M
prep is removed).

Does anyone else feel particularly strongly about this?


ATB,

Mark.