[OpenBIOS] [PATCH 1/2] Implement copy-resolutions-property

Programmingkid programmingkidx at gmail.com
Sun Sep 25 06:58:51 CEST 2016


On Sep 25, 2016, at 12:39 AM, Segher Boessenkool wrote:

> On Sat, Sep 24, 2016 at 12:54:59PM -0400, Programmingkid wrote:
>> +: copy-resolutions-property  ( -- )
>> +    " /options" find-package 
>> +    if 
>> +        active-package!
> 
> You want find-device I guess?

What is the difference between find-device and find-package?

> 
> [ inverted control flow deleted ]

Would you be able to give me an example of what you prefer the code to look like?

> 
>> +    else
>> +        cr ." copy-resolutions-property: Failed to find options node!" cr
>> +    then
> 
> If it's an error, call abort" ; if not, don't say anything?

What advantage does abort" have over the current code?


More information about the OpenBIOS mailing list