[OpenBIOS] [PATCHv2 0/6] PCI address and property fixes

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Mon Jan 4 21:17:44 CET 2016


On 04/01/16 20:11, Programmingkid wrote:

> On Jan 4, 2016, at 9:11 AM, Mark Cave-Ayland wrote:
> 
>> This patchset is a result of work to fix the rtl8139 card under Apple PPC
>> machines in QEMU (both g3beige and mac99).
>>
>> Primarily it fixes up pci_bus_addr_to_host_addr() to support both memory 
>> and IO spaces in order to generate a correct AAPL,address
>> property for IO space mappings. As well as this, it removes the 
>> configuration space range from the PCI host bridge for all machines except
>> SPARC64 which fixes an issue with Darwin/OS X calculating the wrong address
>> spaces for PCI accesses.
>>
>> As a final tidy-up the last patch in the series is a nice rework which 
>> properly generates the PCI node interrupt-map property from the device tree 
>> rather than using hardcoded (and incorrect) properties for openpic.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>
>>
>> v2:
>>  - Updated cover letter
>>  - Remove OLDWORLD() macro typo
>>  - Add constants suggested by Alex
>>  - Include extra patch to tidy up interrupt-map property
>>
>> Mark Cave-Ayland (6):
>>  pci: switch ob_pci_map_in() to use physical addresses rather than
>>    region and size
>>  pci: support PCI spaces other than memory in
>>    pci_bus_addr_to_host_addr()
>>  pci: fix AAPL,address property for IO space mappings
>>  pci: enable AAPL,address property for all Apple PPC machines
>>  pci: remove the configuration space range from the PCI host bridge by
>>    default
>>  pci: don't hard-code PCI interrupt maps by default
>>
>> openbios-devel/drivers/pci.c  |  130 ++++++++++++++++++++++++-----------------
>> openbios-devel/drivers/pci.fs |   68 +++------------------
>> openbios-devel/drivers/pci.h  |    9 +++
>> openbios-devel/drivers/vga.fs |   11 ++--
>> 4 files changed, 100 insertions(+), 118 deletions(-)
>>
>> -- 
>> 1.7.10.4
> 
> 
> I have tried this patch series. It allows the g3beige target to use the RTL8139 NIC, but the mac99 target still does not load the driver for this NIC. For some reason the IOKit is deciding that this device isn't going to have its driver loaded on the mac99 target. Hopefully the unknown requirement will be found.
> 
> Would you like a custom version of the RTL8139 driver for your Darwin installation? I can have it print  information that could help you know if it is working and give you the installation directions. 

Thanks for testing. Unfortunately it works fine for me with -M mac99 and
Darwin 8.0.1 with this patchset so you'll need to work out a test case
that can reproduce the exact problem you're seeing :/

First of all, can you reproduce my setup with Darwin 8.0.1
(darwinppc-801.iso) and -M mac99 and see whether that works for you as a
starting point?


ATB,

Mark.




More information about the OpenBIOS mailing list