[OpenBIOS] [PATCH 0/7] ppc: improve fake copyright message handling

[Mark Cave-Ayland]

On 06/02/16 10:40, Mark Cave-Ayland wrote:

> On 05/02/16 18:33, Alyssa Milburn wrote:
> 
>> On Fri, Feb 05, 2016 at 06:08:59PM +0000, Mark Cave-Ayland wrote:
>>> This series changes the injection of the fake copyright message such
>>> that it is included just before control is handled to the client. The
>>> motivation behind this is that older versions of the MacOS bootloader
>>> don't call the adler32 word which means the injection is omitted and
>>> boot fails.
>>
>> Great, thanks! Seems to work fine for me.
> 
> Excellent!
> 
>>> The first patch is actually a build fix (and will likely be applied
>>> separately) while the rest of the patchset ensures that the message is
>>> only visible to the bootloader client as discussed on the mailing list.
>>
>> This means it is available in the guest OSes too (e.g. in the devicetree
>> under /sys on Linux), which I hope is OK.
> 
> Does adding a call to delete-fake-copyright in ciface_quiesce() as found
> in arch/ppc/qemu/methods.c help here?

Actually I've got a much better idea - the MacOS boot loaders create a
/rom/macos node in the device tree in order for the next stage loader to
access the toolbox. Hence we only need to insert the copyright property
if we detect this node has been created.

I'll include this in the next revision of the copyright patchset for
testing as it seems to work well here.


ATB,

Mark.