[OpenBIOS] [commit] r1379 - trunk/openbios-devel/drivers

repository service svn at openbios.org
Sat Feb 13 14:34:32 CET 2016


Author: mcayland
Date: Sat Feb 13 14:34:31 2016
New Revision: 1379
URL: http://tracker.coreboot.org/trac/openbios/changeset/1379

Log:
pci.c: fix build for non-SPARC/PPC platforms

Commit r1377 accidentally broke compilation with -Werror for platforms without
a default PCI interrupt implementation. Supply a suitable (empty) stub in order
to keep the compiler quiet.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>

Modified:
   trunk/openbios-devel/drivers/pci.c

Modified: trunk/openbios-devel/drivers/pci.c
==============================================================================
--- trunk/openbios-devel/drivers/pci.c	Wed Feb  3 21:46:31 2016	(r1378)
+++ trunk/openbios-devel/drivers/pci.c	Sat Feb 13 14:34:31 2016	(r1379)
@@ -1500,19 +1500,20 @@
 
                     /* Device address is in 1st 32-bit word of encoded PCI address for config space */
                     if ((addr & PCI_RANGE_TYPE_MASK) == PCI_RANGE_CONFIG) {
-#ifdef CONFIG_SPARC64
+#if defined(CONFIG_SPARC64)
                         ncells += pci_encode_phys_addr(props + ncells, 0, 0, addr, 0, 0);
                         props[ncells++] = intno;
                         props[ncells++] = dnode;
                         props[ncells++] = SUN4U_INTERRUPT(addr, intno);
-#endif
-
-#ifdef CONFIG_PPC
+#elif defined(CONFIG_PPC)
                         ncells += pci_encode_phys_addr(props + ncells, 0, 0, addr, 0, 0);
                         props[ncells++] = intno;
                         props[ncells++] = dnode;
                         props[ncells++] = arch->irqs[intno - 1];
                         props[ncells++] = 3;
+#else
+                        /* Keep compiler quiet */
+                        dnode = dnode;
 #endif
                     }
                 }



More information about the OpenBIOS mailing list