[OpenBIOS] [PATCH] drivers/escc.c: Add slot-names property ch-a node under escc

[Programmingkid]

On Feb 9, 2016, at 2:06 PM, Tarl Neustaedter wrote:

> On 2016-Feb-9 13:56 , Programmingkid wrote:
>>>> 
>>>> That is, the first four bytes are supposed to be an integer (in binary) indicating how many names follow, each name null-terminated. The usual case for this properly is that you see 0x00, 0x00, 0x00, 0x01, <string>, 0x00.
>> So is this how it is suppose to be added to OpenBIOS:
>> 
>> 1 encode-int " Modem" encode-string encode+ " slot-names" property
>> 
>> I tried my best to make it look like this:
>> 
>> 00000001
>> Modem
>> 
>> but I just couldn't figure out how. The above code makes the value for slot-names into a bunch of unsightly hexadecimal values. 
> 
> Since it's a mixed-type property (integer, followed by an array of
> strings), unsightly hexadecimal values are inevitable. Assuming Apple
> implements the property per the PCI binding, that is.
> 
> Under OpenBoot (Sun/Oracle's version of IEEE 1275), the slot-names
> properties would generally dump out into a hexadecimal array unless it
> was something which knew the specific format of slot-names. The general
> ".properties" didn't.

I see now. You are saying the problem is with the .properties word. That makes sense. A version 2 of my patch will be made soon.