[OpenBIOS] [PATCH] add copyright message to root node at startup

[Programmingkid]

On Feb 5, 2016, at 3:23 AM, Alyssa Milburn wrote:

> On Fri, Feb 05, 2016 at 12:20:51AM -0500, Programmingkid wrote:
>> Mac OS 9 and earlier require that OpenBIOS has Apple's copyright message in the root node, under the copyright property. This patch adds that message. This patch also removes the code from the adler32 word that did the same thing. Operating systems might need to read the copyright message before the adler32 word is called. So this patch takes care of that problem by supplying the copyright message at startup. This makes the copyright adding code in the adler32 word obsolete. Only the Macintosh emulator will have this message added to the root node. Other machines such as PREP don't run Apple's software so the copyright message will not be added to them.
> 
> Although the Adler32 thing was a neat trick, at this point I think adding it
> at startup is the best approach for compatibility, sadly.
> 
> Why not just add it in tree.fs in plaintext though? Your solution seems kind
> of overcomplicated.

Mark and I don't like the idea of having Apple's copyright in OpenBIOS's code. Apple does have an army of lawyers ready to go after anyone who does something they don't like.

> 
>> @@ -827,10 +853,19 @@
>>         fword("encode-int");
>>         push_str("clock-frequency");
>>         fword("property");
>> +        
>> +        /*
>> +         * We might figure out how to run the classic Mac OS on the g3beige
>> +         * target one day
>> +         */
>> +        add_copyright();
>> +        
> 
> The Beige G3 doesn't have a copyright string in OF, so this seems silly (if
> we eventually add some hack to boot via OF anyway, then we could always add
> it then).

Are you sure the Beige G3 doesn't have a copyright string?