[OpenBIOS] [PATCH] add copyright message to root node at startup

[Mark Cave-Ayland]

On 05/02/16 08:23, Alyssa Milburn wrote:

> On Fri, Feb 05, 2016 at 12:20:51AM -0500, Programmingkid wrote:
>> Mac OS 9 and earlier require that OpenBIOS has Apple's copyright message in the root node, under the copyright property. This patch adds that message. This patch also removes the code from the adler32 word that did the same thing. Operating systems might need to read the copyright message before the adler32 word is called. So this patch takes care of that problem by supplying the copyright message at startup. This makes the copyright adding code in the adler32 word obsolete. Only the Macintosh emulator will have this message added to the root node. Other machines such as PREP don't run Apple's software so the copyright message will not be added to them.
> 
> Although the Adler32 thing was a neat trick, at this point I think adding it
> at startup is the best approach for compatibility, sadly.
> 
> Why not just add it in tree.fs in plaintext though? Your solution seems kind
> of overcomplicated.

If you look back at the archives, the concern is whether or not having
an Apple copyright string visible in the source and at runtime could
cause legal issues with OpenBIOS and ultimately QEMU.

Realistically I don't think Apple could care that much, but without
confirmation from Apple themselves (and the fact that this could also
affect QEMU) then I'd much rather take the safe option.


ATB,

Mark.