[OpenBIOS] [PATCH 3/6] escc: Fix legacy addresses

Mark Cave-Ayland mark.cave-ayland at ilande.co.uk
Tue Aug 2 10:39:15 CEST 2016


On 02/08/16 06:35, Benjamin Herrenschmidt wrote:

> The legacy addresses were incorrect for both ports, fix them.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  drivers/escc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/escc.c b/drivers/escc.c
> index 1990e79..6515475 100644
> --- a/drivers/escc.c
> +++ b/drivers/escc.c
> @@ -405,9 +405,9 @@ escc_add_channel(const char *path, const char *node, phys_addr_t addr,
>              { 0x20, 0x30, 0x50 }
>          },{
>              /* legacy ch-b */
> -            { 0x0, 0x2, 0x8 },
> +            { 0x0, 0x4, 0x8 },
>              /* legacy ch-a */
> -            { 0x4, 0x6, 0xa }
> +            { 0x2, 0x6, 0xa }
>          }
>      };
>      
> 

I remember going through these a while back and thinking that while the
current values didn't match real hardware, they did match what was in
QEMU's hw/misc/macio/macio.c's macio_escc_legacy_setup().

>From memory someone (Alyssa?) picked up on this and posted a patch to
update the mappings in macio_escc_legacy_setup() to match, but I never
got around to digging deeper.


ATB,

Mark.




More information about the OpenBIOS mailing list