[OpenBIOS] [commit] r1395 - trunk/openbios-devel/drivers

repository service svn at openbios.org
Sun Apr 17 16:41:50 CEST 2016


Author: mcayland
Date: Sun Apr 17 16:41:50 2016
New Revision: 1395
URL: http://tracker.coreboot.org/trac/openbios/changeset/1395

Log:
escc.c: add empty ranges property to escc and escc-legacy nodes

This fixes an intermittent panic in the AppleSCCSerial module for MacOS
10.2 and the g3beige machine during initialisation as the module tries to
write to the on-chip registers at 0x130XX rather than calculating the
correct address derived from the parent PCI node.

As described in the IEEE-1275 specification: if a "ranges" property exists but
has a zero-length property value, the child address space is identical to the
parent address space.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>

Modified:
   trunk/openbios-devel/drivers/escc.c

Modified: trunk/openbios-devel/drivers/escc.c
==============================================================================
--- trunk/openbios-devel/drivers/escc.c	Fri Mar 18 14:06:06 2016	(r1394)
+++ trunk/openbios-devel/drivers/escc.c	Sun Apr 17 16:41:50 2016	(r1395)
@@ -514,6 +514,7 @@
     set_property(dnode, "device_type", "escc",
                  strlen("escc") + 1);
     set_property(dnode, "compatible", "escc\0CHRP,es0", 14);
+    set_property(dnode, "ranges", "", 0);
 
     fword("finish-device");
 
@@ -541,6 +542,7 @@
     set_property(dnode, "device_type", "escc-legacy",
                  strlen("escc-legacy") + 1);
     set_property(dnode, "compatible", "chrp,es1", 9);
+    set_property(dnode, "ranges", "", 0);
 
     fword("finish-device");
 



More information about the OpenBIOS mailing list