[OpenBIOS] [PATCH v2 4/4] bootstrap: don't include files from target/include as system includes.

Laurent Vivier lvivier at redhat.com
Sun Oct 25 17:41:33 CET 2015



On 25/10/2015 17:16, Segher Boessenkool wrote:
> On Sun, Oct 25, 2015 at 04:48:53PM +0100, Laurent Vivier wrote:
>> Replace "-I" by "-iquote" to only take files from this directory
>> when '#include "..."' is used ('#include <...>' works as usual)
> 
> Yes :-)
> 
>>  HOSTCFLAGS+= -MMD -MP -MT $@ -MF '$(*D)/$(*F).d'
>> -HOSTINCLUDES := -I$(SRCDIR)/include -I$(SRCDIR)/kernel -I$(SRCDIR)/kernel/include -I$(ODIR)/target/include
>> +HOSTINCLUDES := -I$(SRCDIR)/include -I$(SRCDIR)/kernel -I$(SRCDIR)/kernel/include -iquote $(ODIR)/target/include
> 
> Shouldn't you give these other dirs the same treatment?

Perhaps, but I don't want to break anything with useless changes.

> Line is long btw, split it (with +=)?

I can do that. If a new version of the series is needed I will.

Thank you for your comments,
Laurent



More information about the OpenBIOS mailing list