[OpenBIOS] [PATCH 3/5] On ppc64, asm/sigcontext.h includes asm/elf.h

Segher Boessenkool segher at kernel.crashing.org
Sun Oct 25 17:11:33 CET 2015


On Sun, Oct 25, 2015 at 02:14:40PM +0100, Laurent Vivier wrote:
> >>> asm/sigcontext.h:
> >>>
> >>>     #ifdef __powerpc64__
> >>>     #include <asm/elf.h>
> >>>     #endif
> >>>
> >>> to avoid to include here target/include/asm/elf.h, hardcode the path
> >>> to /usr/include/asm/elf.h in it.
> >> That only works for native builds on powerpc64-linux.  Is that all
> >> that is wanted here?
> > Hmmm that does seem a bit unusual. Is there a better solution for this?
> > Perhaps changing the layout of the OpenBIOS headers to avoid include
> > confusion?
> Yes, I agree with you.
> 
> There are two solutions here:
> 1- normally, "#include <...>" searches firstly in system headers, then
> in "-I" headers, I can seek why it is not the case in the bootstrap case,
> 2- otherwise, we can change the layout, it was what I tried to do first,
> but this implies a lot of changes.

<> searches in the -I path.  "" searches in ., the -iquote path, and then
the -I path.

Maybe OpenBIOS uses -I where it should use -iquote?


Segher



More information about the OpenBIOS mailing list