[OpenBIOS] [PATCH 3/5] On ppc64, asm/sigcontext.h includes asm/elf.h

Laurent Vivier laurent at vivier.eu
Sun Oct 25 14:14:40 CET 2015



On 25/10/2015 12:36, Mark Cave-Ayland wrote:
> On 24/10/15 13:53, Segher Boessenkool wrote:
>
>> On Sat, Oct 24, 2015 at 11:16:59AM +0200, Laurent Vivier wrote:
>>> asm/sigcontext.h:
>>>
>>>     #ifdef __powerpc64__
>>>     #include <asm/elf.h>
>>>     #endif
>>>
>>> to avoid to include here target/include/asm/elf.h, hardcode the path
>>> to /usr/include/asm/elf.h in it.
>> That only works for native builds on powerpc64-linux.  Is that all
>> that is wanted here?
> Hmmm that does seem a bit unusual. Is there a better solution for this?
> Perhaps changing the layout of the OpenBIOS headers to avoid include
> confusion?
Yes, I agree with you.

There are two solutions here:
1- normally, "#include <...>" searches firstly in system headers, then
in "-I" headers, I can seek why it is not the case in the bootstrap case,
2- otherwise, we can change the layout, it was what I tried to do first,
but this implies a lot of changes.

I'm going to try to find a solution using the first one, feel free to
include the other patches from the series if they are ok for you.

Laurent
 




More information about the OpenBIOS mailing list