[OpenBIOS] [PATCH v2 0/4] Build openbios on powerpc64 host
laurent at vivier.eu
Mon Nov 2 00:19:17 CET 2015
Le 01/11/2015 23:46, Mark Cave-Ayland a écrit :
> On 25/10/15 15:48, Laurent Vivier wrote:
>> This series of patches allows to build openbios on a
>> powerpc64 host. It has been tested with the following targets:
>> ppc, sparc32, sparc64. It has also been tested on x86_64 host
>> with the same targets.
>> v2: remove patches 3/5 and 4/5 of the first series and replace it
>> with patch 4/4. We don't include the system includes using
>> full pathname but use '-iquote' intead of '-I'
>> A preliminary patch is needed for fcode-utils, as "toke" is
>> broken on big endian architecture:
>> diff -ru fcode-utils/toke/scanner.c fcode-utils-new/toke/scanner.c
>> --- fcode-utils/toke/scanner.c 2006-10-30 09:48:28.000000000 +0100
>> +++ fcode-utils-new/toke/scanner.c 2015-10-19 00:21:43.417373690 +0200
>> @@ -1625,7 +1625,7 @@
>> void user_message( tic_param_t pfield )
>> - char delim = (char)pfield.deflt_elem ;
>> + char delim = (char)pfield.fw_token ;
>> handle_user_message( delim, TRUE);
>> @@ -5295,7 +5295,7 @@
>> void process_remark( tic_param_t pfield )
>> - char until_char = (char)pfield.deflt_elem ;
>> + char until_char = (char)pfield.fw_token ;
>> unsigned int start_lineno = lineno;
>> #ifdef DEBUG_SCANNER
>> Laurent Vivier (4):
>> switch-arch: factorize code to compute architecture properties.
>> switch-arch: compute base arch and allow native compiler for 32bit
>> and 64bit.
>> switch-arch: as for powerpc64, select sparc64 compiler to compile
>> bootstrap: don't include files from target/include as system includes.
>> Makefile.target | 2 +-
>> config/scripts/switch-arch | 85 +++++++++++++++++++++++++---------------------
>> include/arch/ppc/types.h | 8 -----
>> 3 files changed, 48 insertions(+), 47 deletions(-)
> Hi Laurent,
> I've done some tests here on both x86 and PPC hardware and the basic
> patchset works well here. The only issue I found is that git-am
> complains about whitespace errors during application - if you could
> resubmit the series with this fixed, that would be great.
Can I have more details, I've tried to "git-am" the patches I have
generated and I had no troubles (do you have some git hooks ?)
> As for the toke fix, I don't know this code particularly well but I can
> at least confirm that when applied it still produces valid binaries.
> Could you send a separate patch in "git style" explaining what bug this
> patch fixes, and if it looks good then I'll apply it too.
> Many thanks,
More information about the OpenBIOS